fix: Link error on Windows due to shared symbols #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reduction of shared dependencies in AcademySoftwareFoundation#1890, there is an unresolved OSLCompiler constructor symbol when linking liboslexec. Avoid including the oslcomp_pvt.h header that causes this. Signed-off-by: Brecht Van Lommel <[email protected]>
brechtvl
force-pushed
the
fix-oslcomp-shared-windows
branch
from
8b10ad2 to
35cb276
Compare
Contributor
Author
|
I have not actually tested this on Windows, but I'm fairly confident so I'll post this PR for others to try in #1860. |
|
Tested it , builds and links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After reduction of shared dependencies in #1890, there is an unresolved OSLCompiler constructor symbol when linking liboslexec. Avoid including the oslcomp_pvt.h header that causes this.
Tests
N/A
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.